Skip to content

fix: remove duplicate hash fragment in HashRouter redirect (#364)#506

Merged
indresh404 merged 1 commit into
indresh404:mainfrom
5hivam123:fix/double-hash-url-approuter
Jun 14, 2026
Merged

fix: remove duplicate hash fragment in HashRouter redirect (#364)#506
indresh404 merged 1 commit into
indresh404:mainfrom
5hivam123:fix/double-hash-url-approuter

Conversation

@5hivam123

Copy link
Copy Markdown
Contributor

Description

Removed window.location.hash from the HashRouter redirect logic
in App.jsx to prevent duplicate hash fragments like
/#/dashboard#/dashboard from being generated.

Related Issue

Fixes #364

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots / Videos (if applicable)

[Add screenshot of URL bar showing clean redirect without double hash]

Testing Done

  • Visual verification on local dev server (http://localhost:5173)
  • Navigating to app with hash URL redirects cleanly ✅
  • No double hash fragments in URL ✅
  • No console errors or warnings

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings or console errors.

Contributor Declaration

  • I confirm that this contribution is made under the rules of NSoC 2026.
  • I confirm that I have been assigned the related issue by a maintainer before opening this PR.
  • I have read the Contributing Guidelines and Code of Conduct.

@5hivam123 5hivam123 requested a review from indresh404 as a code owner June 14, 2026 05:53
@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ranker-hub Ready Ready Preview, Comment Jun 14, 2026 5:53am

@github-actions github-actions Bot added backend Backend/Firebase related changes bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request frontend Frontend related changes (HTML/CSS/JS/React) gssoc GirlScript Summer of Code gssoc26 GirlScript Summer of Code 2026 nsoc NSoC NSoC'26 NSoC 2026 pending-review PR is pending review labels Jun 14, 2026
@5hivam123

5hivam123 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Hi @indresh404! 👋

I've fixed this issue.

Changes made in src/App.jsx:

  • Removed window.location.hash from redirect logic

Please review when you get a chance. Thanks! 🙏

@indresh404 indresh404 added level2 and removed level3 labels Jun 14, 2026
@indresh404 indresh404 merged commit 8cc7647 into indresh404:main Jun 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Backend/Firebase related changes bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request frontend Frontend related changes (HTML/CSS/JS/React) gssoc GirlScript Summer of Code gssoc26 GirlScript Summer of Code 2026 level2 nsoc NSoC NSoC'26 NSoC 2026 pending-review PR is pending review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Bug]: Potential double hash URL issue in HashRouter redirect logic in App.jsx

2 participants